From 81faf7d8abde47c63e0f344c2849780e86f84879 Mon Sep 17 00:00:00 2001
From: Pierre <63404022+0-Pierre@users.noreply.github.com>
Date: Thu, 20 Mar 2025 12:57:01 +0100
Subject: [PATCH] fix: remove redundant try/catch since error is already
 handled with fetchCoverArt.catch()

---
 server/api/coverartarchive/index.ts | 43 ++++++++++++-----------------
 1 file changed, 18 insertions(+), 25 deletions(-)

diff --git a/server/api/coverartarchive/index.ts b/server/api/coverartarchive/index.ts
index 389bdf09..ce96cbb5 100644
--- a/server/api/coverartarchive/index.ts
+++ b/server/api/coverartarchive/index.ts
@@ -186,32 +186,25 @@ class CoverArtArchive extends ExternalAPI {
     }
 
     if (idsToFetch.length > 0) {
-      try {
-        const batchPromises = idsToFetch.map((id) =>
-          this.fetchCoverArt(id)
-            .then((response) => {
-              const frontImage = response.images.find((img) => img.front);
-              resultsMap.set(id, frontImage?.thumbnails?.[250] || null);
-              return true;
-            })
-            .catch((error) => {
-              logger.error('Failed to fetch cover art', {
-                label: 'CoverArtArchive',
-                id,
-                error: error instanceof Error ? error.message : 'Unknown error',
-              });
-              resultsMap.set(id, null);
-              return false;
-            })
-        );
+      const batchPromises = idsToFetch.map((id) =>
+        this.fetchCoverArt(id)
+          .then((response) => {
+            const frontImage = response.images.find((img) => img.front);
+            resultsMap.set(id, frontImage?.thumbnails?.[250] || null);
+            return true;
+          })
+          .catch((error) => {
+            logger.error('Failed to fetch cover art', {
+              label: 'CoverArtArchive',
+              id,
+              error: error instanceof Error ? error.message : 'Unknown error',
+            });
+            resultsMap.set(id, null);
+            return false;
+          })
+      );
 
-        await Promise.allSettled(batchPromises);
-      } catch (error) {
-        logger.error('Failed to process cover art requests', {
-          label: 'CoverArtArchive',
-          error: error instanceof Error ? error.message : 'Unknown error',
-        });
-      }
+      await Promise.allSettled(batchPromises);
     }
 
     const results: Record<string, string | null> = {};