From a46cdb3a4f4f0a963c1f10d8c283ddfa7f46eb8e Mon Sep 17 00:00:00 2001
From: gauthier-th <mail@gauthierth.fr>
Date: Tue, 25 Jun 2024 15:39:14 +0200
Subject: [PATCH] fix: send proper URL params

---
 server/api/externalapi.ts           | 22 ++++++++++------------
 server/api/rating/rottentomatoes.ts |  3 +--
 2 files changed, 11 insertions(+), 14 deletions(-)

diff --git a/server/api/externalapi.ts b/server/api/externalapi.ts
index 70cd37b9..76666f01 100644
--- a/server/api/externalapi.ts
+++ b/server/api/externalapi.ts
@@ -60,7 +60,7 @@ class ExternalAPI {
     }
 
     const url = this.formatUrl(endpoint, params);
-    const response = await fetch(url.href, {
+    const response = await fetch(url, {
       ...config,
       headers: {
         ...this.defaultHeaders,
@@ -93,7 +93,7 @@ class ExternalAPI {
     }
 
     const url = this.formatUrl(endpoint, params);
-    const response = await fetch(url.href, {
+    const response = await fetch(url, {
       method: 'POST',
       ...config,
       headers: {
@@ -128,7 +128,7 @@ class ExternalAPI {
     }
 
     const url = this.formatUrl(endpoint, params);
-    const response = await fetch(url.href, {
+    const response = await fetch(url, {
       method: 'PUT',
       ...config,
       headers: {
@@ -152,7 +152,7 @@ class ExternalAPI {
     config?: RequestInit
   ): Promise<T> {
     const url = this.formatUrl(endpoint, params);
-    const response = await fetch(url.href, {
+    const response = await fetch(url, {
       ...config,
       headers: {
         ...this.defaultHeaders,
@@ -186,7 +186,7 @@ class ExternalAPI {
         Date.now() - DEFAULT_ROLLING_BUFFER
       ) {
         const url = this.formatUrl(endpoint, params, overwriteBaseUrl);
-        fetch(url.href, {
+        fetch(url, {
           ...config,
           headers: {
             ...this.defaultHeaders,
@@ -201,7 +201,7 @@ class ExternalAPI {
     }
 
     const url = this.formatUrl(endpoint, params, overwriteBaseUrl);
-    const response = await fetch(url.href, {
+    const response = await fetch(url, {
       ...config,
       headers: {
         ...this.defaultHeaders,
@@ -228,12 +228,10 @@ class ExternalAPI {
       (baseUrl.endsWith('/') ? '' : '/') +
       (endpoint.startsWith('/') ? endpoint.slice(1) : endpoint);
     const url = new URL(href);
-    if (params) {
-      url.search = new URLSearchParams({
-        ...this.params,
-        ...params,
-      }).toString();
-    }
+    url.search = new URLSearchParams({
+      ...this.params,
+      ...params,
+    }).toString();
     return url;
   }
 
diff --git a/server/api/rating/rottentomatoes.ts b/server/api/rating/rottentomatoes.ts
index d89bb03a..e86c2488 100644
--- a/server/api/rating/rottentomatoes.ts
+++ b/server/api/rating/rottentomatoes.ts
@@ -63,8 +63,7 @@ class RottenTomatoes extends ExternalAPI {
     super(
       'https://79frdp12pn-dsn.algolia.net/1/indexes/*',
       {
-        'x-algolia-agent':
-          'Algolia%20for%20JavaScript%20(4.14.3)%3B%20Browser%20(lite)',
+        'x-algolia-agent': 'Algolia for JavaScript (4.14.3); Browser (lite)',
         'x-algolia-api-key': '175588f6e5f8319b27702e4cc4013561',
         'x-algolia-application-id': '79FRDP12PN',
       },