From dd4b6fd859c409e2c13be38b26b17a9693c0d9a4 Mon Sep 17 00:00:00 2001 From: Gauthier Date: Sun, 10 Nov 2024 16:48:32 +0100 Subject: [PATCH] perf: remove eager load of Blacklist entity from Media entity Try to resolve some performance issues by removing the eager loading of Blacklist items from the Media entity --- server/entity/Blacklist.ts | 4 ++-- server/entity/Media.ts | 6 ++---- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/server/entity/Blacklist.ts b/server/entity/Blacklist.ts index 5e24419d..4ce3a86e 100644 --- a/server/entity/Blacklist.ts +++ b/server/entity/Blacklist.ts @@ -80,12 +80,12 @@ export class Blacklist implements BlacklistItem { status: MediaStatus.BLACKLISTED, status4k: MediaStatus.BLACKLISTED, mediaType: blacklistRequest.mediaType, - blacklist: blacklist, + blacklist: Promise.resolve(blacklist), }); await mediaRepository.save(media); } else { - media.blacklist = blacklist; + media.blacklist = Promise.resolve(blacklist); media.status = MediaStatus.BLACKLISTED; media.status4k = MediaStatus.BLACKLISTED; diff --git a/server/entity/Media.ts b/server/entity/Media.ts index de10cebc..a9991dc4 100644 --- a/server/entity/Media.ts +++ b/server/entity/Media.ts @@ -118,10 +118,8 @@ class Media { @OneToMany(() => Issue, (issue) => issue.media, { cascade: true }) public issues: Issue[]; - @OneToOne(() => Blacklist, (blacklist) => blacklist.media, { - eager: true, - }) - public blacklist: Blacklist; + @OneToOne(() => Blacklist, (blacklist) => blacklist.media) + public blacklist: Promise; @CreateDateColumn() public createdAt: Date;