chore: update to Node.js v22

.github/workflows/ci.yml

@@ -13,7 +13,7 @@ jobs:
     name: Lint & Test Build
     if: github.event_name == 'pull_request'
     runs-on: ubuntu-22.04
-    container: node:20-alpine
+    container: node:22-alpine
     steps:
       - name: Checkout
         uses: actions/checkout@v4

.github/workflows/cypress.yml

@@ -17,7 +17,7 @@ jobs:
       - name: Set up Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: 20
+          node-version: 22
       - name: Pnpm Setup
         uses: pnpm/action-setup@v4
         with:

.github/workflows/docs-deploy.yml

@@ -20,7 +20,7 @@ jobs:
       - name: Set up Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: 20
+          node-version: 22
 
       - name: Pnpm Setup
         uses: pnpm/action-setup@v4

.github/workflows/release.yml

@@ -16,7 +16,7 @@ jobs:
       - name: Set up Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: 20
+          node-version: 22
       - name: Set up QEMU
         uses: docker/setup-qemu-action@v3
       - name: Set up Docker Buildx

.github/workflows/test-docs-deploy.yml

@@ -20,7 +20,7 @@ jobs:
       - name: Set up Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: 20
+          node-version: 22
 
       - name: Pnpm Setup
         uses: pnpm/action-setup@v4

CONTRIBUTING.md

@@ -8,7 +8,7 @@ All help is welcome and greatly appreciated! If you would like to contribute to
 
 - HTML/Typescript/Javascript editor
 - [VSCode](https://code.visualstudio.com/) is recommended. Upon opening the project, a few extensions will be automatically recommended for install.
-- [NodeJS](https://nodejs.org/en/download/) (Node 20.x)
+- [NodeJS](https://nodejs.org/en/download/) (Node 22.x)
 - [Pnpm](https://pnpm.io/cli/install)
 - [Git](https://git-scm.com/downloads)
 

Dockerfile

@@ -1,4 +1,4 @@
-FROM node:20-alpine AS BUILD_IMAGE
+FROM node:22-alpine AS BUILD_IMAGE
 
 WORKDIR /app
 
@@ -36,7 +36,7 @@ RUN touch config/DOCKER
 RUN echo "{\"commitTag\": \"${COMMIT_TAG}\"}" > committag.json
 
 
-FROM node:20-alpine
+FROM node:22-alpine
 
 # Metadata for Github Package Registry
 LABEL org.opencontainers.image.source="https://github.com/Fallenbagel/jellyseerr"

Dockerfile.local

@@ -1,4 +1,4 @@
-FROM node:20-alpine
+FROM node:22-alpine
 
 COPY . /app
 WORKDIR /app

next-env.d.ts

@@ -2,4 +2,4 @@
 /// <reference types="next/image-types/global" />
 
 // NOTE: This file should not be edited
-// see https://nextjs.org/docs/basic-features/typescript for more information.
+// see https://nextjs.org/docs/pages/building-your-application/configuring/typescript for more information.

package.json

@@ -43,7 +43,6 @@
     "@svgr/webpack": "6.5.1",
     "@tanem/react-nprogress": "5.0.30",
     "ace-builds": "1.15.2",
-    "axios": "^1.7.7",
     "bcrypt": "5.1.0",
     "bowser": "2.11.0",
     "connect-typeorm": "1.1.4",
@@ -169,7 +168,7 @@
     "typescript": "4.9.5"
   },
   "engines": {
-    "node": "^20.0.0",
+    "node": "^22.0.0",
     "pnpm": "^9.0.0"
   },
   "overrides": {

server/api/externalapi.ts

@@ -1,6 +1,5 @@
-import type { AxiosInstance, AxiosRequestConfig } from 'axios';
+import type { RateLimitOptions } from '@server/utils/rateLimit';
-import axios from 'axios';
+import rateLimit from '@server/utils/rateLimit';
-// import rateLimit from 'axios-rate-limit';
 import type NodeCache from 'node-cache';
 
 // 5 minute default TTL (in seconds)
@@ -12,71 +11,101 @@ const DEFAULT_ROLLING_BUFFER = 10000;
 interface ExternalAPIOptions {
   nodeCache?: NodeCache;
   headers?: Record<string, unknown>;
-  rateLimit?: {
+  rateLimit?: RateLimitOptions;
-    maxRPS: number;
-    maxRequests: number;
-  };
 }
 
 class ExternalAPI {
-  protected axios: AxiosInstance;
+  protected fetch: typeof fetch;
+  protected params: Record<string, string>;
+  protected defaultHeaders: { [key: string]: string };
   private baseUrl: string;
   private cache?: NodeCache;
 
   constructor(
     baseUrl: string,
-    params: Record<string, unknown>,
+    params: Record<string, string> = {},
     options: ExternalAPIOptions = {}
   ) {
-    this.axios = axios.create({
+    if (options.rateLimit) {
-      baseURL: baseUrl,
+      this.fetch = rateLimit(fetch, options.rateLimit);
-      params,
+    } else {
-      headers: {
+      this.fetch = fetch;
+    }
+
+    const url = new URL(baseUrl);
+
+    this.defaultHeaders = {
       'Content-Type': 'application/json',
       Accept: 'application/json',
+      ...((url.username || url.password) && {
+        Authorization: `Basic ${Buffer.from(
+          `${url.username}:${url.password}`
+        ).toString('base64')}`,
+      }),
       ...options.headers,
-      },
+    };
-    });
 
-    // if (options.rateLimit) {
+    if (url.username || url.password) {
-    //   this.axios = rateLimit(this.axios, {
+      url.username = '';
-    //     maxRequests: options.rateLimit.maxRequests,
+      url.password = '';
-    //     maxRPS: options.rateLimit.maxRPS,
+      baseUrl = url.toString();
-    //   });
+    }
-    // }
 
     this.baseUrl = baseUrl;
+    this.params = params;
     this.cache = options.nodeCache;
   }
 
   protected async get<T>(
     endpoint: string,
-    config?: AxiosRequestConfig,
+    params?: Record<string, string>,
-    ttl?: number
+    ttl?: number,
+    config?: RequestInit
   ): Promise<T> {
-    const cacheKey = this.serializeCacheKey(endpoint, config?.params);
+    const cacheKey = this.serializeCacheKey(endpoint, {
+      ...this.params,
+      ...params,
+    });
     const cachedItem = this.cache?.get<T>(cacheKey);
     if (cachedItem) {
       return cachedItem;
     }
 
-    const response = await this.axios.get<T>(endpoint, config);
+    const url = this.formatUrl(endpoint, params);
+    const response = await this.fetch(url, {
+      ...config,
+      headers: {
+        ...this.defaultHeaders,
+        ...config?.headers,
+      },
+    });
+    if (!response.ok) {
+      const text = await response.text();
+      throw new Error(
+        `${response.status} ${response.statusText}${text ? ': ' + text : ''}`,
+        {
+          cause: response,
+        }
+      );
+    }
+    const data = await this.getDataFromResponse(response);
 
-    if (this.cache) {
+    if (this.cache && ttl !== 0) {
-      this.cache.set(cacheKey, response.data, ttl ?? DEFAULT_TTL);
+      this.cache.set(cacheKey, data, ttl ?? DEFAULT_TTL);
     }
 
-    return response.data;
+    return data;
   }
 
   protected async post<T>(
     endpoint: string,
     data?: Record<string, unknown>,
-    config?: AxiosRequestConfig,
+    params?: Record<string, string>,
-    ttl?: number
+    ttl?: number,
+    config?: RequestInit
   ): Promise<T> {
     const cacheKey = this.serializeCacheKey(endpoint, {
-      config: config?.params,
+      config: { ...this.params, ...params },
       data,
     });
     const cachedItem = this.cache?.get<T>(cacheKey);
@@ -84,23 +113,43 @@ class ExternalAPI {
       return cachedItem;
     }
 
-    const response = await this.axios.post<T>(endpoint, data, config);
+    const url = this.formatUrl(endpoint, params);
+    const response = await this.fetch(url, {
+      method: 'POST',
+      ...config,
+      headers: {
+        ...this.defaultHeaders,
+        ...config?.headers,
+      },
+      body: data ? JSON.stringify(data) : undefined,
+    });
+    if (!response.ok) {
+      const text = await response.text();
+      throw new Error(
+        `${response.status} ${response.statusText}${text ? ': ' + text : ''}`,
+        {
+          cause: response,
+        }
+      );
+    }
+    const resData = await this.getDataFromResponse(response);
 
-    if (this.cache) {
+    if (this.cache && ttl !== 0) {
-      this.cache.set(cacheKey, response.data, ttl ?? DEFAULT_TTL);
+      this.cache.set(cacheKey, resData, ttl ?? DEFAULT_TTL);
     }
 
-    return response.data;
+    return resData;
   }
 
   protected async put<T>(
     endpoint: string,
     data: Record<string, unknown>,
-    config?: AxiosRequestConfig,
+    params?: Record<string, string>,
-    ttl?: number
+    ttl?: number,
+    config?: RequestInit
   ): Promise<T> {
     const cacheKey = this.serializeCacheKey(endpoint, {
-      config: config?.params,
+      config: { ...this.params, ...params },
       data,
     });
     const cachedItem = this.cache?.get<T>(cacheKey);
@@ -108,41 +157,73 @@ class ExternalAPI {
       return cachedItem;
     }
 
-    const response = await this.axios.put<T>(endpoint, data, config);
+    const url = this.formatUrl(endpoint, params);
+    const response = await this.fetch(url, {
+      method: 'PUT',
+      ...config,
+      headers: {
+        ...this.defaultHeaders,
+        ...config?.headers,
+      },
+      body: JSON.stringify(data),
+    });
+    if (!response.ok) {
+      const text = await response.text();
+      throw new Error(
+        `${response.status} ${response.statusText}${text ? ': ' + text : ''}`,
+        {
+          cause: response,
+        }
+      );
+    }
+    const resData = await this.getDataFromResponse(response);
 
-    if (this.cache) {
+    if (this.cache && ttl !== 0) {
-      this.cache.set(cacheKey, response.data, ttl ?? DEFAULT_TTL);
+      this.cache.set(cacheKey, resData, ttl ?? DEFAULT_TTL);
     }
 
-    return response.data;
+    return resData;
   }
 
   protected async delete<T>(
     endpoint: string,
-    config?: AxiosRequestConfig,
+    params?: Record<string, string>,
-    ttl?: number
+    config?: RequestInit
   ): Promise<T> {
-    const cacheKey = this.serializeCacheKey(endpoint, config?.params);
+    const url = this.formatUrl(endpoint, params);
-    const cachedItem = this.cache?.get<T>(cacheKey);
+    const response = await this.fetch(url, {
-    if (cachedItem) {
+      method: 'DELETE',
-      return cachedItem;
+      ...config,
+      headers: {
+        ...this.defaultHeaders,
+        ...config?.headers,
+      },
+    });
+    if (!response.ok) {
+      const text = await response.text();
+      throw new Error(
+        `${response.status} ${response.statusText}${text ? ': ' + text : ''}`,
+        {
+          cause: response,
         }
-
+      );
-    const response = await this.axios.delete<T>(endpoint, config);
-
-    if (this.cache) {
-      this.cache.set(cacheKey, response.data, ttl ?? DEFAULT_TTL);
     }
+    const data = await this.getDataFromResponse(response);
 
-    return response.data;
+    return data;
   }
 
   protected async getRolling<T>(
     endpoint: string,
-    config?: AxiosRequestConfig,
+    params?: Record<string, string>,
-    ttl?: number
+    ttl?: number,
+    config?: RequestInit,
+    overwriteBaseUrl?: string
   ): Promise<T> {
-    const cacheKey = this.serializeCacheKey(endpoint, config?.params);
+    const cacheKey = this.serializeCacheKey(endpoint, {
+      ...this.params,
+      ...params,
+    });
     const cachedItem = this.cache?.get<T>(cacheKey);
 
     if (cachedItem) {
@@ -153,20 +234,78 @@ class ExternalAPI {
         keyTtl - (ttl ?? DEFAULT_TTL) * 1000 <
         Date.now() - DEFAULT_ROLLING_BUFFER
       ) {
-        this.axios.get<T>(endpoint, config).then((response) => {
+        const url = this.formatUrl(endpoint, params, overwriteBaseUrl);
-          this.cache?.set(cacheKey, response.data, ttl ?? DEFAULT_TTL);
+        this.fetch(url, {
+          ...config,
+          headers: {
+            ...this.defaultHeaders,
+            ...config?.headers,
+          },
+        }).then(async (response) => {
+          if (!response.ok) {
+            const text = await response.text();
+            throw new Error(
+              `${response.status} ${response.statusText}${
+                text ? ': ' + text : ''
+              }`,
+              {
+                cause: response,
+              }
+            );
+          }
+          const data = await this.getDataFromResponse(response);
+          this.cache?.set(cacheKey, data, ttl ?? DEFAULT_TTL);
         });
       }
       return cachedItem;
     }
 
-    const response = await this.axios.get<T>(endpoint, config);
+    const url = this.formatUrl(endpoint, params, overwriteBaseUrl);
+    const response = await this.fetch(url, {
+      ...config,
+      headers: {
+        ...this.defaultHeaders,
+        ...config?.headers,
+      },
+    });
+    if (!response.ok) {
+      const text = await response.text();
+      throw new Error(
+        `${response.status} ${response.statusText}${text ? ': ' + text : ''}`,
+        {
+          cause: response,
+        }
+      );
+    }
+    const data = await this.getDataFromResponse(response);
 
     if (this.cache) {
-      this.cache.set(cacheKey, response.data, ttl ?? DEFAULT_TTL);
+      this.cache.set(cacheKey, data, ttl ?? DEFAULT_TTL);
     }
 
-    return response.data;
+    return data;
+  }
+
+  private formatUrl(
+    endpoint: string,
+    params?: Record<string, string>,
+    overwriteBaseUrl?: string
+  ): string {
+    const baseUrl = overwriteBaseUrl || this.baseUrl;
+    const href =
+      baseUrl +
+      (baseUrl.endsWith('/') ? '' : '/') +
+      (endpoint.startsWith('/') ? endpoint.slice(1) : endpoint);
+    const searchParams = new URLSearchParams({
+      ...this.params,
+      ...params,
+    });
+    return (
+      href +
+      (searchParams.toString().length
+        ? '?' + searchParams.toString()
+        : searchParams.toString())
+    );
   }
 
   private serializeCacheKey(
@@ -179,6 +318,29 @@ class ExternalAPI {
 
     return `${this.baseUrl}${endpoint}${JSON.stringify(params)}`;
   }
+
+  private async getDataFromResponse(response: Response) {
+    const contentType = response.headers.get('Content-Type');
+    if (contentType?.includes('application/json')) {
+      return await response.json();
+    } else if (
+      contentType?.includes('application/xml') ||
+      contentType?.includes('text/html') ||
+      contentType?.includes('text/plain')
+    ) {
+      return await response.text();
+    } else {
+      try {
+        return await response.json();
+      } catch {
+        try {
+          return await response.blob();
+        } catch {
+          return null;
+        }
+      }
+    }
+  }
 }
 
 export default ExternalAPI;

server/api/github.ts

@@ -1,6 +1,6 @@
+import ExternalAPI from '@server/api/externalapi';
 import cacheManager from '@server/lib/cache';
 import logger from '@server/logger';
-import ExternalAPI from './externalapi';
 
 interface GitHubRelease {
   url: string;
@@ -67,10 +67,6 @@ class GithubAPI extends ExternalAPI {
       'https://api.github.com',
       {},
       {
-        headers: {
-          'Content-Type': 'application/json',
-          Accept: 'application/json',
-        },
         nodeCache: cacheManager.getCache('github').data,
       }
     );
@@ -85,9 +81,7 @@ class GithubAPI extends ExternalAPI {
       const data = await this.get<GitHubRelease[]>(
         '/repos/fallenbagel/jellyseerr/releases',
         {
-          params: {
+          per_page: take.toString(),
-            per_page: take,
-          },
         }
       );
 
@@ -112,10 +106,8 @@ class GithubAPI extends ExternalAPI {
       const data = await this.get<GithubCommit[]>(
         '/repos/fallenbagel/jellyseerr/commits',
         {
-          params: {
+          per_page: take.toString(),
-            per_page: take,
           branch,
-          },
         }
       );
 

server/api/jellyfin.ts

@@ -129,6 +129,8 @@ class JellyfinAPI extends ExternalAPI {
           Username,
           Pw: Password,
         },
+        {},
+        undefined,
         { headers }
       );
     };
@@ -291,7 +293,6 @@ class JellyfinAPI extends ExternalAPI {
       const libraryItemsResponse = await this.get<any>(
         `/Users/${this.userId}/Items`,
         {
-          params: {
           SortBy: 'SortName',
           SortOrder: 'Ascending',
           IncludeItemTypes: 'Series,Movie,Others',
@@ -299,7 +300,6 @@ class JellyfinAPI extends ExternalAPI {
           StartIndex: '0',
           ParentId: id,
           collapseBoxSetItems: 'false',
-          },
         }
       );
 
@@ -321,10 +321,8 @@ class JellyfinAPI extends ExternalAPI {
       const itemResponse = await this.get<any>(
         `/Users/${this.userId}/Items/Latest`,
         {
-          params: {
           Limit: '12',
           ParentId: id,
-          },
         }
       );
 
@@ -386,9 +384,7 @@ class JellyfinAPI extends ExternalAPI {
       const episodeResponse = await this.get<any>(
         `/Shows/${seriesID}/Episodes`,
         {
-          params: {
           seasonId: seasonID,
-          },
         }
       );
 

server/api/plextv.ts

@@ -1,9 +1,9 @@
+import ExternalAPI from '@server/api/externalapi';
 import type { PlexDevice } from '@server/interfaces/api/plexInterfaces';
 import cacheManager from '@server/lib/cache';
 import { getSettings } from '@server/lib/settings';
 import logger from '@server/logger';
 import xml2js from 'xml2js';
-import ExternalAPI from './externalapi';
 
 interface PlexAccountResponse {
   user: PlexUser;
@@ -137,8 +137,6 @@ class PlexTvAPI extends ExternalAPI {
       {
         headers: {
           'X-Plex-Token': authToken,
-          'Content-Type': 'application/json',
-          Accept: 'application/json',
         },
         nodeCache: cacheManager.getCache('plextv').data,
       }
@@ -149,15 +147,11 @@ class PlexTvAPI extends ExternalAPI {
 
   public async getDevices(): Promise<PlexDevice[]> {
     try {
-      const devicesResp = await this.axios.get(
+      const devicesResp = await this.get('/api/resources', {
-        '/api/resources?includeHttps=1',
+        includeHttps: '1',
-        {
+      });
-          transformResponse: [],
-          responseType: 'text',
-        }
-      );
       const parsedXml = await xml2js.parseStringPromise(
-        devicesResp.data as DeviceResponse
+        devicesResp as DeviceResponse
       );
       return parsedXml?.MediaContainer?.Device?.map((pxml: DeviceResponse) => ({
         name: pxml.$.name,
@@ -205,11 +199,11 @@ class PlexTvAPI extends ExternalAPI {
 
   public async getUser(): Promise<PlexUser> {
     try {
-      const account = await this.axios.get<PlexAccountResponse>(
+      const account = await this.get<PlexAccountResponse>(
         '/users/account.json'
       );
 
-      return account.data.user;
+      return account.user;
     } catch (e) {
       logger.error(
         `Something went wrong while getting the account from plex.tv: ${e.message}`,
@@ -249,13 +243,10 @@ class PlexTvAPI extends ExternalAPI {
   }
 
   public async getUsers(): Promise<UsersResponse> {
-    const response = await this.axios.get('/api/users', {
+    const data = await this.get('/api/users');
-      transformResponse: [],
-      responseType: 'text',
-    });
 
     const parsedXml = (await xml2js.parseStringPromise(
-      response.data
+      data as string
     )) as UsersResponse;
     return parsedXml;
   }
@@ -270,25 +261,26 @@ class PlexTvAPI extends ExternalAPI {
     items: PlexWatchlistItem[];
   }> {
     try {
-      const response = await this.axios.get<WatchlistResponse>(
+      const params = new URLSearchParams({
-        '/library/sections/watchlist/all',
+        'X-Plex-Container-Start': offset.toString(),
+        'X-Plex-Container-Size': size.toString(),
+      });
+      const response = await this.fetch(
+        `https://metadata.provider.plex.tv/library/sections/watchlist/all?${params.toString()}`,
         {
-          params: {
+          headers: this.defaultHeaders,
-            'X-Plex-Container-Start': offset,
-            'X-Plex-Container-Size': size,
-          },
-          baseURL: 'https://metadata.provider.plex.tv',
         }
       );
+      const data = (await response.json()) as WatchlistResponse;
 
       const watchlistDetails = await Promise.all(
-        (response.data.MediaContainer.Metadata ?? []).map(
+        (data.MediaContainer.Metadata ?? []).map(async (watchlistItem) => {
-          async (watchlistItem) => {
           const detailedResponse = await this.getRolling<MetadataResponse>(
             `/library/metadata/${watchlistItem.ratingKey}`,
-              {
+            {},
-                baseURL: 'https://metadata.provider.plex.tv',
+            undefined,
-              }
+            {},
+            'https://metadata.provider.plex.tv'
           );
 
           const metadata = detailedResponse.MediaContainer.Metadata[0];
@@ -311,8 +303,7 @@ class PlexTvAPI extends ExternalAPI {
             title: metadata.title,
             type: metadata.type,
           };
-          }
+        })
-        )
       );
 
       const filteredList = watchlistDetails.filter((detail) => detail.tmdbId);
@@ -320,7 +311,7 @@ class PlexTvAPI extends ExternalAPI {
       return {
         offset,
         size,
-        totalSize: response.data.MediaContainer.totalSize,
+        totalSize: data.MediaContainer.totalSize,
         items: filteredList,
       };
     } catch (e) {

server/api/pushover.ts

@@ -1,4 +1,4 @@
-import ExternalAPI from './externalapi';
+import ExternalAPI from '@server/api/externalapi';
 
 interface PushoverSoundsResponse {
   sounds: {
@@ -26,24 +26,13 @@ export const mapSounds = (sounds: {
 
 class PushoverAPI extends ExternalAPI {
   constructor() {
-    super(
+    super('https://api.pushover.net/1');
-      'https://api.pushover.net/1',
-      {},
-      {
-        headers: {
-          'Content-Type': 'application/json',
-          Accept: 'application/json',
-        },
-      }
-    );
   }
 
   public async getSounds(appToken: string): Promise<PushoverSound[]> {
     try {
       const data = await this.get<PushoverSoundsResponse>('/sounds.json', {
-        params: {
         token: appToken,
-        },
       });
 
       return mapSounds(data.sounds);

server/api/servarr/base.ts

@@ -160,10 +160,8 @@ class ServarrBase<QueueItemAppendT> extends ExternalAPI {
       const data = await this.get<QueueResponse<QueueItemAppendT>>(
         `/queue`,
         {
-          params: {
           includeEpisode: 'true',
         },
-        },
         0
       );
 

server/api/servarr/radarr.ts

@@ -58,9 +58,7 @@ class RadarrAPI extends ServarrBase<{ movieId: number }> {
   public async getMovieByTmdbId(id: number): Promise<RadarrMovie> {
     try {
       const data = await this.get<RadarrMovie[]>('/movie/lookup', {
-        params: {
         term: `tmdb:${id}`,
-        },
       });
 
       if (!data[0]) {
@@ -224,10 +222,8 @@ class RadarrAPI extends ServarrBase<{ movieId: number }> {
     try {
       const { id, title } = await this.getMovieByTmdbId(movieId);
       await this.delete(`/movie/${id}`, {
-        params: {
         deleteFiles: 'true',
         addImportExclusion: 'false',
-        },
       });
       logger.info(`[Radarr] Removed movie ${title}`);
     } catch (e) {

server/api/servarr/sonarr.ts

@@ -138,9 +138,7 @@ class SonarrAPI extends ServarrBase<{
   public async getSeriesByTitle(title: string): Promise<SonarrSeries[]> {
     try {
       const data = await this.get<SonarrSeries[]>('/series/lookup', {
-        params: {
         term: title,
-        },
       });
 
       if (!data[0]) {
@@ -161,9 +159,7 @@ class SonarrAPI extends ServarrBase<{
   public async getSeriesByTvdbId(id: number): Promise<SonarrSeries> {
     try {
       const data = await this.get<SonarrSeries[]>('/series/lookup', {
-        params: {
         term: `tvdb:${id}`,
-        },
       });
 
       if (!data[0]) {
@@ -349,10 +345,8 @@ class SonarrAPI extends ServarrBase<{
     try {
       const { id, title } = await this.getSeriesByTvdbId(serieId);
       await this.delete(`/series/${id}`, {
-        params: {
         deleteFiles: 'true',
         addImportExclusion: 'false',
-        },
       });
       logger.info(`[Radarr] Removed serie ${title}`);
     } catch (e) {

server/api/tautulli.ts

@@ -1,8 +1,7 @@
+import ExternalAPI from '@server/api/externalapi';
 import type { User } from '@server/entity/User';
 import type { TautulliSettings } from '@server/lib/settings';
 import logger from '@server/logger';
-import type { AxiosInstance } from 'axios';
-import axios from 'axios';
 import { uniqWith } from 'lodash';
 
 export interface TautulliHistoryRecord {
@@ -113,25 +112,25 @@ interface TautulliInfoResponse {
   };
 }
 
-class TautulliAPI {
+class TautulliAPI extends ExternalAPI {
-  private axios: AxiosInstance;
-
   constructor(settings: TautulliSettings) {
-    this.axios = axios.create({
+    super(
-      baseURL: `${settings.useSsl ? 'https' : 'http'}://${settings.hostname}:${
+      `${settings.useSsl ? 'https' : 'http'}://${settings.hostname}:${
         settings.port
       }${settings.urlBase ?? ''}`,
-      params: { apikey: settings.apiKey },
+      {
-    });
+        apikey: settings.apiKey || '',
+      }
+    );
   }
 
   public async getInfo(): Promise<TautulliInfo> {
     try {
       return (
-        await this.axios.get<TautulliInfoResponse>('/api/v2', {
+        await this.get<TautulliInfoResponse>('/api/v2', {
-          params: { cmd: 'get_tautulli_info' },
+          cmd: 'get_tautulli_info',
         })
-      ).data.response.data;
+      ).response.data;
     } catch (e) {
       logger.error('Something went wrong fetching Tautulli server info', {
         label: 'Tautulli API',
@@ -148,14 +147,12 @@ class TautulliAPI {
   ): Promise<TautulliWatchStats[]> {
     try {
       return (
-        await this.axios.get<TautulliWatchStatsResponse>('/api/v2', {
+        await this.get<TautulliWatchStatsResponse>('/api/v2', {
-          params: {
           cmd: 'get_item_watch_time_stats',
           rating_key: ratingKey,
-            grouping: 1,
+          grouping: '1',
-          },
         })
-      ).data.response.data;
+      ).response.data;
     } catch (e) {
       logger.error(
         'Something went wrong fetching media watch stats from Tautulli',
@@ -176,14 +173,12 @@ class TautulliAPI {
   ): Promise<TautulliWatchUser[]> {
     try {
       return (
-        await this.axios.get<TautulliWatchUsersResponse>('/api/v2', {
+        await this.get<TautulliWatchUsersResponse>('/api/v2', {
-          params: {
           cmd: 'get_item_user_stats',
           rating_key: ratingKey,
-            grouping: 1,
+          grouping: '1',
-          },
         })
-      ).data.response.data;
+      ).response.data;
     } catch (e) {
       logger.error(
         'Something went wrong fetching media watch users from Tautulli',
@@ -206,15 +201,13 @@ class TautulliAPI {
       }
 
       return (
-        await this.axios.get<TautulliWatchStatsResponse>('/api/v2', {
+        await this.get<TautulliWatchStatsResponse>('/api/v2', {
-          params: {
           cmd: 'get_user_watch_time_stats',
-            user_id: user.plexId,
+          user_id: user.plexId.toString(),
-            query_days: 0,
+          query_days: '0',
-            grouping: 1,
+          grouping: '1',
-          },
         })
-      ).data.response.data[0];
+      ).response.data[0];
     } catch (e) {
       logger.error(
         'Something went wrong fetching user watch stats from Tautulli',
@@ -245,19 +238,17 @@ class TautulliAPI {
 
       while (results.length < 20) {
         const tautulliData = (
-          await this.axios.get<TautulliHistoryResponse>('/api/v2', {
+          await this.get<TautulliHistoryResponse>('/api/v2', {
-            params: {
             cmd: 'get_history',
-              grouping: 1,
+            grouping: '1',
             order_column: 'date',
             order_dir: 'desc',
-              user_id: user.plexId,
+            user_id: user.plexId.toString(),
             media_type: 'movie,episode',
-              length: take,
+            length: take.toString(),
-              start,
+            start: start.toString(),
-            },
           })
-        ).data.response.data.data;
+        ).response.data.data;
 
         if (!tautulliData.length) {
           return results;

server/api/themoviedb/index.ts

@@ -112,10 +112,10 @@ class TheMovieDb extends ExternalAPI {
       },
       {
         nodeCache: cacheManager.getCache('tmdb').data,
-        // rateLimit: {
+        rateLimit: {
-        //   maxRPS: 50,
+          maxRPS: 50,
-        //   id: 'tmdb',
+          id: 'tmdb',
-        // },
+        },
       }
     );
     this.region = region;
@@ -130,12 +130,10 @@ class TheMovieDb extends ExternalAPI {
   }: SearchOptions): Promise<TmdbSearchMultiResponse> => {
     try {
       const data = await this.get<TmdbSearchMultiResponse>('/search/multi', {
-        params: {
         query,
         page: page.toString(),
         include_adult: includeAdult ? 'true' : 'false',
         language,
-        },
       });
 
       return data;
@@ -158,13 +156,11 @@ class TheMovieDb extends ExternalAPI {
   }: SingleSearchOptions): Promise<TmdbSearchMovieResponse> => {
     try {
       const data = await this.get<TmdbSearchMovieResponse>('/search/movie', {
-        params: {
         query,
         page: page.toString(),
         include_adult: includeAdult ? 'true' : 'false',
         language,
         primary_release_year: year?.toString() || '',
-        },
       });
 
       return data;
@@ -187,13 +183,11 @@ class TheMovieDb extends ExternalAPI {
   }: SingleSearchOptions): Promise<TmdbSearchTvResponse> => {
     try {
       const data = await this.get<TmdbSearchTvResponse>('/search/tv', {
-        params: {
         query,
         page: page.toString(),
         include_adult: includeAdult ? 'true' : 'false',
         language,
         first_air_date_year: year?.toString() || '',
-        },
       });
 
       return data;
@@ -216,9 +210,7 @@ class TheMovieDb extends ExternalAPI {
   }): Promise<TmdbPersonDetails> => {
     try {
       const data = await this.get<TmdbPersonDetails>(`/person/${personId}`, {
-        params: {
         language,
-        },
       });
 
       return data;
@@ -238,9 +230,7 @@ class TheMovieDb extends ExternalAPI {
       const data = await this.get<TmdbPersonCombinedCredits>(
         `/person/${personId}/combined_credits`,
         {
-          params: {
           language,
-          },
         }
       );
 
@@ -263,12 +253,10 @@ class TheMovieDb extends ExternalAPI {
       const data = await this.get<TmdbMovieDetails>(
         `/movie/${movieId}`,
         {
-          params: {
           language,
           append_to_response:
             'credits,external_ids,videos,keywords,release_dates,watch/providers',
         },
-        },
         43200
       );
 
@@ -289,12 +277,10 @@ class TheMovieDb extends ExternalAPI {
       const data = await this.get<TmdbTvDetails>(
         `/tv/${tvId}`,
         {
-          params: {
           language,
           append_to_response:
             'aggregate_credits,credits,external_ids,keywords,videos,content_ratings,watch/providers',
         },
-        },
         43200
       );
 
@@ -317,10 +303,8 @@ class TheMovieDb extends ExternalAPI {
       const data = await this.get<TmdbSeasonWithEpisodes>(
         `/tv/${tvId}/season/${seasonNumber}`,
         {
-          params: {
           language: language || '',
           append_to_response: 'external_ids',
-          },
         }
       );
 
@@ -343,10 +327,8 @@ class TheMovieDb extends ExternalAPI {
       const data = await this.get<TmdbSearchMovieResponse>(
         `/movie/${movieId}/recommendations`,
         {
-          params: {
           page: page.toString(),
           language,
-          },
         }
       );
 
@@ -369,10 +351,8 @@ class TheMovieDb extends ExternalAPI {
       const data = await this.get<TmdbSearchMovieResponse>(
         `/movie/${movieId}/similar`,
         {
-          params: {
           page: page.toString(),
           language,
-          },
         }
       );
 
@@ -395,10 +375,8 @@ class TheMovieDb extends ExternalAPI {
       const data = await this.get<TmdbSearchMovieResponse>(
         `/keyword/${keywordId}/movies`,
         {
-          params: {
           page: page.toString(),
           language,
-          },
         }
       );
 
@@ -421,10 +399,8 @@ class TheMovieDb extends ExternalAPI {
       const data = await this.get<TmdbSearchTvResponse>(
         `/tv/${tvId}/recommendations`,
         {
-          params: {
           page: page.toString(),
           language,
-          },
         }
       );
 
@@ -447,10 +423,8 @@ class TheMovieDb extends ExternalAPI {
   }): Promise<TmdbSearchTvResponse> {
     try {
       const data = await this.get<TmdbSearchTvResponse>(`/tv/${tvId}/similar`, {
-        params: {
         page: page.toString(),
         language,
-        },
       });
 
       return data;
@@ -491,7 +465,6 @@ class TheMovieDb extends ExternalAPI {
         .split('T')[0];
 
       const data = await this.get<TmdbSearchMovieResponse>('/discover/movie', {
-        params: {
         sort_by: sortBy,
         page: page.toString(),
         include_adult: includeAdult ? 'true' : 'false',
@@ -524,7 +497,6 @@ class TheMovieDb extends ExternalAPI {
         'vote_count.lte': voteCountLte || '',
         watch_region: watchRegion || '',
         with_watch_providers: watchProviders || '',
-        },
       });
 
       return data;
@@ -566,7 +538,6 @@ class TheMovieDb extends ExternalAPI {
         .split('T')[0];
 
       const data = await this.get<TmdbSearchTvResponse>('/discover/tv', {
-        params: {
         sort_by: sortBy,
         page: page.toString(),
         language,
@@ -602,7 +573,6 @@ class TheMovieDb extends ExternalAPI {
         with_watch_providers: watchProviders || '',
         watch_region: watchRegion || '',
         with_status: withStatus || '',
-        },
       });
 
       return data;
@@ -622,12 +592,10 @@ class TheMovieDb extends ExternalAPI {
       const data = await this.get<TmdbUpcomingMoviesResponse>(
         '/movie/upcoming',
         {
-          params: {
           page: page.toString(),
           language,
           region: this.region || '',
           originalLanguage: this.originalLanguage || '',
-          },
         }
       );
 
@@ -650,11 +618,9 @@ class TheMovieDb extends ExternalAPI {
       const data = await this.get<TmdbSearchMultiResponse>(
         `/trending/all/${timeWindow}`,
         {
-          params: {
           page: page.toString(),
           language,
           region: this.region || '',
-          },
         }
       );
 
@@ -675,9 +641,7 @@ class TheMovieDb extends ExternalAPI {
       const data = await this.get<TmdbSearchMovieResponse>(
         `/trending/movie/${timeWindow}`,
         {
-          params: {
           page: page.toString(),
-          },
         }
       );
 
@@ -698,9 +662,7 @@ class TheMovieDb extends ExternalAPI {
       const data = await this.get<TmdbSearchTvResponse>(
         `/trending/tv/${timeWindow}`,
         {
-          params: {
           page: page.toString(),
-          },
         }
       );
 
@@ -729,10 +691,8 @@ class TheMovieDb extends ExternalAPI {
       const data = await this.get<TmdbExternalIdResponse>(
         `/find/${externalId}`,
         {
-          params: {
           external_source: type === 'imdb' ? 'imdb_id' : 'tvdb_id',
           language,
-          },
         }
       );
 
@@ -822,9 +782,7 @@ class TheMovieDb extends ExternalAPI {
       const data = await this.get<TmdbCollection>(
         `/collection/${collectionId}`,
         {
-          params: {
           language,
-          },
         }
       );
 
@@ -897,10 +855,8 @@ class TheMovieDb extends ExternalAPI {
       const data = await this.get<TmdbGenresResult>(
         '/genre/movie/list',
         {
-          params: {
           language,
         },
-        },
         86400 // 24 hours
       );
 
@@ -911,10 +867,8 @@ class TheMovieDb extends ExternalAPI {
         const englishData = await this.get<TmdbGenresResult>(
           '/genre/movie/list',
           {
-            params: {
             language: 'en',
           },
-          },
           86400 // 24 hours
         );
 
@@ -948,10 +902,8 @@ class TheMovieDb extends ExternalAPI {
       const data = await this.get<TmdbGenresResult>(
         '/genre/tv/list',
         {
-          params: {
           language,
         },
-        },
         86400 // 24 hours
       );
 
@@ -962,10 +914,8 @@ class TheMovieDb extends ExternalAPI {
         const englishData = await this.get<TmdbGenresResult>(
           '/genre/tv/list',
           {
-            params: {
             language: 'en',
           },
-          },
           86400 // 24 hours
         );
 
@@ -1019,11 +969,9 @@ class TheMovieDb extends ExternalAPI {
       const data = await this.get<TmdbKeywordSearchResponse>(
         '/search/keyword',
         {
-          params: {
           query,
           page: page.toString(),
         },
-        },
         86400 // 24 hours
       );
 
@@ -1044,11 +992,9 @@ class TheMovieDb extends ExternalAPI {
       const data = await this.get<TmdbCompanySearchResponse>(
         '/search/company',
         {
-          params: {
           query,
           page: page.toString(),
         },
-        },
         86400 // 24 hours
       );
 
@@ -1067,10 +1013,8 @@ class TheMovieDb extends ExternalAPI {
       const data = await this.get<{ results: TmdbWatchProviderRegion[] }>(
         '/watch/providers/regions',
         {
-          params: {
           language: language ? this.originalLanguage || '' : '',
         },
-        },
         86400 // 24 hours
       );
 
@@ -1093,11 +1037,9 @@ class TheMovieDb extends ExternalAPI {
       const data = await this.get<{ results: TmdbWatchProviderDetails[] }>(
         '/watch/providers/movie',
         {
-          params: {
           language: language ? this.originalLanguage || '' : '',
           watch_region: watchRegion,
         },
-        },
         86400 // 24 hours
       );
 
@@ -1120,11 +1062,9 @@ class TheMovieDb extends ExternalAPI {
       const data = await this.get<{ results: TmdbWatchProviderDetails[] }>(
         '/watch/providers/tv',
         {
-          params: {
           language: language ? this.originalLanguage || '' : '',
           watch_region: watchRegion,
         },
-        },
         86400 // 24 hours
       );