fix(overriderules): test service using the right endpoint (#2399)

This commit is contained in:
Gauthier
2026-02-10 13:18:56 +01:00
committed by GitHub
parent e3dc1c302d
commit 028c7c2434

View File

@@ -11,11 +11,7 @@ import globalMessages from '@app/i18n/globalMessages';
import defineMessages from '@app/utils/defineMessages';
import { Transition } from '@headlessui/react';
import type OverrideRule from '@server/entity/OverrideRule';
import type {
DVRSettings,
RadarrSettings,
SonarrSettings,
} from '@server/lib/settings';
import type { RadarrSettings, SonarrSettings } from '@server/lib/settings';
import axios from 'axios';
import { Field, Formik } from 'formik';
import { useCallback, useEffect, useState } from 'react';
@@ -81,23 +77,26 @@ const OverrideRuleModal = ({
});
const getServiceInfos = useCallback(
async ({
hostname,
port,
apiKey,
baseUrl,
useSsl = false,
}: {
hostname: string;
port: number;
apiKey: string;
baseUrl?: string;
useSsl?: boolean;
}) => {
async (
{
hostname,
port,
apiKey,
baseUrl,
useSsl = false,
}: {
hostname: string;
port: number;
apiKey: string;
baseUrl?: string;
useSsl?: boolean;
},
type: 'radarr' | 'sonarr'
) => {
setIsTesting(true);
try {
const response = await axios.post<DVRTestResponse>(
'/api/v1/settings/sonarr/test',
`/api/v1/settings/${type}/test`,
{
hostname,
apiKey,
@@ -119,15 +118,19 @@ const OverrideRuleModal = ({
);
useEffect(() => {
let service: DVRSettings | null = null;
if (rule?.radarrServiceId !== null && rule?.radarrServiceId !== undefined) {
service = radarrServices[rule?.radarrServiceId] || null;
if (
rule?.radarrServiceId !== null &&
rule?.radarrServiceId !== undefined &&
radarrServices[rule?.radarrServiceId]
) {
getServiceInfos(radarrServices[rule?.radarrServiceId], 'radarr');
}
if (rule?.sonarrServiceId !== null && rule?.sonarrServiceId !== undefined) {
service = sonarrServices[rule?.sonarrServiceId] || null;
}
if (service) {
getServiceInfos(service);
if (
rule?.sonarrServiceId !== null &&
rule?.sonarrServiceId !== undefined &&
sonarrServices[rule?.sonarrServiceId]
) {
getServiceInfos(sonarrServices[rule?.sonarrServiceId], 'sonarr');
}
}, [
getServiceInfos,
@@ -256,13 +259,13 @@ const OverrideRuleModal = ({
setFieldValue('radarrServiceId', id);
setFieldValue('sonarrServiceId', null);
if (radarrServices[id]) {
getServiceInfos(radarrServices[id]);
getServiceInfos(radarrServices[id], 'radarr');
}
} else if (e.target.value.startsWith('sonarr-')) {
setFieldValue('radarrServiceId', null);
setFieldValue('sonarrServiceId', id);
if (sonarrServices[id]) {
getServiceInfos(sonarrServices[id]);
getServiceInfos(sonarrServices[id], 'sonarr');
}
} else {
setFieldValue('radarrServiceId', null);