fix(jellyfinscanner): conditionally assign the jellyfinMediaId and jellyfinMediaId4k

Previously `jellyfinMediaId4k` was being assigned even if 4k server was not setup or even if 4k
content were not present. This fixes it by conditionally assigning the jellyfinMediaId and
JellyfinMediaId4k

fix #681

.github/FUNDING.yml

@@ -1 +1 @@
-github: [Fallenbagel]
+github: [Fallenbagel]

server/api/jellyfin.ts

@@ -9,12 +9,6 @@ export interface JellyfinUserResponse {
   ServerId: string;
   ServerName: string;
   Id: string;
-  Configuration: {
-    GroupedFolders: string[];
-  };
-  Policy: {
-    IsAdministrator: boolean;
-  };
   PrimaryImageTag?: string;
 }
 
@@ -27,13 +21,6 @@ export interface JellyfinUserListResponse {
   users: JellyfinUserResponse[];
 }
 
-interface JellyfinMediaFolder {
-  Name: string;
-  Id: string;
-  Type: string;
-  CollectionType: string;
-}
-
 export interface JellyfinLibrary {
   type: 'show' | 'movie';
   key: string;
@@ -185,45 +172,24 @@ class JellyfinAPI {
 
   public async getLibraries(): Promise<JellyfinLibrary[]> {
     try {
-      const mediaFolders = await this.axios.get<any>(`/Library/MediaFolders`);
+      // TODO: Try to fix automatic grouping without fucking up LDAP users
+      // const libraries = await this.axios.get<any>('/Library/VirtualFolders');
 
-      return this.mapLibraries(mediaFolders.data.Items);
-    } catch (mediaFoldersError) {
-      // fallback to user views to get libraries
-      // this only affects LDAP users
-      try {
-        const mediaFolders = await this.axios.get<any>(
-          `/Users/${this.userId ?? 'Me'}/Views`
-        );
+      const account = await this.axios.get<any>(
+        `/Users/${this.userId ?? 'Me'}/Views`
+      );
 
-        return this.mapLibraries(mediaFolders.data.Items);
-      } catch (e) {
-        logger.error(
-          `Something went wrong while getting libraries from the Jellyfin server: ${e.message}`,
-          { label: 'Jellyfin API' }
-        );
-        return [];
-      }
-    }
-  }
-
-  private mapLibraries(mediaFolders: JellyfinMediaFolder[]): JellyfinLibrary[] {
-    const excludedTypes = [
-      'music',
-      'books',
-      'musicvideos',
-      'homevideos',
-      'boxsets',
-    ];
-
-    return mediaFolders
-      .filter((Item: JellyfinMediaFolder) => {
-        return (
-          Item.Type === 'CollectionFolder' &&
-          !excludedTypes.includes(Item.CollectionType)
-        );
-      })
-      .map((Item: JellyfinMediaFolder) => {
+      const response: JellyfinLibrary[] = account.data.Items.filter(
+        (Item: any) => {
+          return (
+            Item.Type === 'CollectionFolder' &&
+            Item.CollectionType !== 'music' &&
+            Item.CollectionType !== 'books' &&
+            Item.CollectionType !== 'musicvideos' &&
+            Item.CollectionType !== 'homevideos'
+          );
+        }
+      ).map((Item: any) => {
         return <JellyfinLibrary>{
           key: Item.Id,
           title: Item.Name,
@@ -231,12 +197,21 @@ class JellyfinAPI {
           agent: 'jellyfin',
         };
       });
+
+      return response;
+    } catch (e) {
+      logger.error(
+        `Something went wrong while getting libraries from the Jellyfin server: ${e.message}`,
+        { label: 'Jellyfin API' }
+      );
+      return [];
+    }
   }
 
   public async getLibraryContents(id: string): Promise<JellyfinLibraryItem[]> {
     try {
       const contents = await this.axios.get<any>(
-        `/Users/${this.userId}/Items?SortBy=SortName&SortOrder=Ascending&IncludeItemTypes=Series,Movie,Others&Recursive=true&StartIndex=0&ParentId=${id}&collapseBoxSetItems=false`
+        `/Users/${this.userId}/Items?SortBy=SortName&SortOrder=Ascending&IncludeItemTypes=Series,Movie,Others&Recursive=true&StartIndex=0&ParentId=${id}`
       );
 
       return contents.data.Items.filter(

server/routes/auth.ts

@@ -276,11 +276,6 @@ authRoutes.post('/jellyfin', async (req, res, next) => {
     });
 
     if (!user && !(await userRepository.count())) {
-      // Check if user is admin on jellyfin
-      if (account.User.Policy.IsAdministrator === false) {
-        throw new Error('not_admin');
-      }
-
       logger.info(
         'Sign-in attempt from Jellyfin user with access to the media server; creating initial admin user for Overseerr',
         {
@@ -428,11 +423,6 @@ authRoutes.post('/jellyfin', async (req, res, next) => {
         status: 401,
         message: 'Unauthorized',
       });
-    } else if (e.message === 'not_admin') {
-      return next({
-        status: 403,
-        message: 'CREDENTIAL_ERROR_NOT_ADMIN',
-      });
     } else if (e.message === 'add_email') {
       return next({
         status: 406,

server/routes/settings/index.ts

@@ -261,7 +261,7 @@ settingsRoutes.post('/jellyfin', (req, res) => {
   return res.status(200).json(settings.jellyfin);
 });
 
-settingsRoutes.get('/jellyfin/library', async (req, res, next) => {
+settingsRoutes.get('/jellyfin/library', async (req, res) => {
   const settings = getSettings();
 
   if (req.query.sync) {
@@ -281,19 +281,6 @@ settingsRoutes.get('/jellyfin/library', async (req, res, next) => {
 
     const libraries = await jellyfinClient.getLibraries();
 
-    if (libraries.length === 0) {
-      // Check if no libraries are found due to the fallback to user views
-      // This only affects LDAP users
-      const account = await jellyfinClient.getUser();
-
-      // Automatic Library grouping is not supported when user views are used to get library
-      if (account.Configuration.GroupedFolders.length > 0) {
-        return next({ status: 501, message: 'SYNC_ERROR_GROUPED_FOLDERS' });
-      }
-
-      return next({ status: 404, message: 'SYNC_ERROR_NO_LIBRARIES' });
-    }
-
     const newLibraries: Library[] = libraries.map((library) => {
       const existing = settings.jellyfin.libraries.find(
         (l) => l.id === library.key && l.name === library.title

src/components/Login/JellyfinLogin.tsx

@@ -24,7 +24,6 @@ const messages = defineMessages({
   validationusernamerequired: 'Username required',
   validationpasswordrequired: 'Password required',
   loginerror: 'Something went wrong while trying to sign in.',
-  adminerror: 'You must use an admin account to sign in.',
   credentialerror: 'The username or password is incorrect.',
   signingin: 'Signing in…',
   signin: 'Sign In',
@@ -95,8 +94,6 @@ const JellyfinLogin: React.FC<JellyfinLoginProps> = ({
               intl.formatMessage(
                 e.message == 'Request failed with status code 401'
                   ? messages.credentialerror
-                  : e.message == 'Request failed with status code 403'
-                  ? messages.adminerror
                   : messages.loginerror
               ),
               {

src/components/Settings/SettingsJellyfin.tsx

@@ -34,11 +34,6 @@ const messages = defineMessages({
   externalUrl: 'External URL',
   internalUrl: 'Internal URL',
   jellyfinForgotPasswordUrl: 'Forgot Password URL',
-  jellyfinSyncFailedNoLibrariesFound: 'No libraries were found',
-  jellyfinSyncFailedAutomaticGroupedFolders:
-    'Custom authentication with Automatic Library Grouping not supported',
-  jellyfinSyncFailedGenericError:
-    'Something went wrong while syncing libraries',
   validationUrl: 'You must provide a valid URL',
   syncing: 'Syncing',
   syncJellyfin: 'Sync Libraries',
@@ -75,7 +70,6 @@ const SettingsJellyfin: React.FC<SettingsJellyfinProps> = ({
   showAdvancedSettings,
 }) => {
   const [isSyncing, setIsSyncing] = useState(false);
-  const toasts = useToasts();
 
   const {
     data,
@@ -123,43 +117,11 @@ const SettingsJellyfin: React.FC<SettingsJellyfinProps> = ({
       params.enable = activeLibraries.join(',');
     }
 
-    try {
-      await axios.get('/api/v1/settings/jellyfin/library', {
-        params,
-      });
-      setIsSyncing(false);
-      revalidate();
-    } catch (e) {
-      if (e.response.data.message === 'SYNC_ERROR_GROUPED_FOLDERS') {
-        toasts.addToast(
-          intl.formatMessage(
-            messages.jellyfinSyncFailedAutomaticGroupedFolders
-          ),
-          {
-            autoDismiss: true,
-            appearance: 'warning',
-          }
-        );
-      } else if (e.response.data.message === 'SYNC_ERROR_NO_LIBRARIES') {
-        toasts.addToast(
-          intl.formatMessage(messages.jellyfinSyncFailedNoLibrariesFound),
-          {
-            autoDismiss: true,
-            appearance: 'error',
-          }
-        );
-      } else {
-        toasts.addToast(
-          intl.formatMessage(messages.jellyfinSyncFailedGenericError),
-          {
-            autoDismiss: true,
-            appearance: 'error',
-          }
-        );
-      }
-      setIsSyncing(false);
-      revalidate();
-    }
+    await axios.get('/api/v1/settings/jellyfin/library', {
+      params,
+    });
+    setIsSyncing(false);
+    revalidate();
   };
 
   const startScan = async () => {

src/i18n/locale/en.json

@@ -220,7 +220,6 @@
   "components.Layout.VersionStatus.streamdevelop": "Overseerr Develop",
   "components.Layout.VersionStatus.streamstable": "Overseerr Stable",
   "components.Login.credentialerror": "The username or password is incorrect.",
-  "components.Login.adminerror": "You must use an admin account to sign in.",
   "components.Login.description": "Since this is your first time logging into {applicationName}, you are required to add a valid email address.",
   "components.Login.email": "Email Address",
   "components.Login.emailtooltip": "Address does not need to be associated with your {mediaServerName} instance.",
@@ -946,9 +945,6 @@
   "components.Settings.jellyfinlibrariesDescription": "The libraries {mediaServerName} scans for titles. Click the button below if no libraries are listed.",
   "components.Settings.jellyfinsettings": "{mediaServerName} Settings",
   "components.Settings.jellyfinsettingsDescription": "Configure the settings for your {mediaServerName} server. {mediaServerName} scans your {mediaServerName} libraries to see what content is available.",
-  "components.Settings.jellyfinSyncFailedNoLibrariesFound": "No libraries were found",
-  "components.Settings.jellyfinSyncFailedAutomaticGroupedFolders": "Custom authentication with Automatic Library Grouping not supported",
-  "components.Settings.jellyfinSyncFailedGenericError": "Something went wrong while syncing libraries",
   "components.Settings.librariesRemaining": "Libraries Remaining: {count}",
   "components.Settings.manualscan": "Manual Library Scan",
   "components.Settings.manualscanDescription": "Normally, this will only be run once every 24 hours. Overseerr will check your Plex server's recently added more aggressively. If this is your first time configuring Plex, a one-time full manual library scan is recommended!",